Checklist for a payments-touching PR
Domain-aware review checklists -- payments, auth, infra -- so reviewers don't miss the obvious
Zobrazit náhled vstupu a výstupu
Vstup
- Language
- TypeScript
- Domain
- payments
- Risk
- high
Výstup (úryvek)
## Code review checklist -- payments PR (high risk) - [ ] All money handled as integer cents (no float arithmetic anywhere in the diff). - [ ] Currency code travels alongside every amount (no implicit USD). - [ ] Idempotency key required on every write to the gateway; reuse checked against a 24h store. - [ ] PII (card last4, billing address) never logged, including in error stack traces. - [ ] DB writes wrapped in a transaction with the gateway call after commit. - [ ] Tests cover: success, 3DS challenge, declined, gateway timeout, partial refund, double-submit replay. - [ ] Feature flag in place; rollout plan documented in PR description.